fix(tui): auto-dismiss skill loaded notices after 3 seconds#11
Merged
Conversation
Transient notices (skill loaded, memory, signal, subagent logs) were piling up because every new event reset the single expiry sweep timer. Now each transient notice gets its own 3-second sweep, so expired notices are pruned independently instead of waiting for a quiet gap. - Reduce noticeTTL from 5s to 3s. - Always prune on noticeExpireMsg; drop the stale-sequence guard that delayed expiry when newer notices arrived.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transient notices (skill loaded, memory, signal, subagent logs) were piling up because every new event reset the single expiry sweep timer.
This change gives each transient notice its own 3-second sweep, so expired notices are pruned independently instead of waiting for a quiet gap.
Changes:
noticeTTLfrom 5s to 3s.noticeExpireMsg; drop the stale-sequence guard that delayed expiry when newer notices arrived.Verified with
go test -race -count=1 ./internal/tui/...andgo vet ./... && go build ./....